test: fix ts compiler errors - #23130
Conversation
fb546ee to
cf2f917
Compare
31c6698 to
8523d25
Compare
|
I've added a commit adding the BUILDs for the legacy-cli where all the compiler errors are and added the compilation of these to circleci. With all the changes landing keeping this PR up to date with the fixes without the a bazel build (#23074) is quite the hassle. Adding the actual bazel build to CI ensures this PR is up to date and correctly fixes the compilation errors. While the bazel build of legacy-cli is unnecessary right now (other then for type checking) I think it's worth avoiding compilation errors. When these tests are moved to bazel (#23074) this will be required anyway, which hopefully will be finished soon 🤞 |
52db560 to
9b79605
Compare
8c22b57 to
f8b7931
Compare
|
I've reverted the addition of |
clydin
left a comment
There was a problem hiding this comment.
LGTM.
Some of these changes would fail linting checks but these files are not linted yet and would need other cleanup prior to that anyway.
|
I can maybe do linting next but really need type checking before anything else 👍 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
When compiling with the standard
tsc(directly or viats_libraryin bazel) there are a lot of compilation errors in the e2e tests which the runtimelib/bootstrap-local.jscompilation seems to ignore. These are fixes required to get a standard compiler working such as bazel in #23074